By Kyle Goslan


2012-08-08 10:47:41 8 Comments

Just started using Xcode 4.5 and I got this error in the console:

Warning: Attempt to present < finishViewController: 0x1e56e0a0 > on < ViewController: 0x1ec3e000> whose view is not in the window hierarchy!

The view is still being presented and everything in the app is working fine. Is this something new in iOS 6?

This is the code I'm using to change between views:

UIStoryboard *storyboard = self.storyboard;
finishViewController *finished = 
[storyboard instantiateViewControllerWithIdentifier:@"finishViewController"];

[self presentViewController:finished animated:NO completion:NULL];

26 comments

@sunkehappy 2012-12-06 05:35:24

I also encountered this problem when I tried to present a UIViewController in viewDidLoad. James Bedford's answer worked, but my app showed the background first for 1 or 2 seconds.

After some research, I've found a way to solve this using the addChildViewController.

- (void)viewDidLoad
{
    ...
    [self.view addSubview: navigationViewController.view];
    [self addChildViewController: navigationViewController];
    ...
}

@foFox 2013-07-26 22:54:33

I think you are missing [navigationViewController didMoveToParentViewController:self]

@Logicsaurus Rex 2016-04-20 01:21:18

I tried your code, along with foFox's suggestion, and when I go to remove it from it's parent, it won't go away. Lololol. Still stuck with no fix.

@Kang Byul 2017-04-06 05:42:30

Works in Swift3.1

@Iyyappan Ravi 2017-04-11 12:03:49

@sunkehappy above two lines to be used in before presentviewcontroller, but its crashed why?

@George_E 2018-09-29 23:01:30

In my situation, I was not able to put mine in a class override. So, here is what I got:

let viewController = self // I had viewController passed in as a function,
                          // but otherwise you can do this


// Present the view controller
let currentViewController = UIApplication.shared.keyWindow?.rootViewController
currentViewController?.dismiss(animated: true, completion: nil)

if viewController.presentedViewController == nil {
    currentViewController?.present(alert, animated: true, completion: nil)
} else {
    viewController.present(alert, animated: true, completion: nil)
}

@saltwat5r 2018-06-11 08:33:18

This kind of warning can mean that You're trying to present new View Controller through Navigation Controller while this Navigation Controller is currently presenting another View Controller. To fix it You have to dismiss currently presented View Controller at first and on completion present the new one. Another cause of the warning can be trying to present View Controller on thread another than main.

@Fan Jin 2018-06-07 20:45:36

Sadly, the accepted solution did not work for my case. I was trying to navigate to a new View Controller right after unwind from another View Controller.

I found a solution by using a flag to indicate which unwind segue was called.

@IBAction func unwindFromAuthenticationWithSegue(segue: UIStoryboardSegue) {
    self.shouldSegueToMainTabBar = true
}

@IBAction func unwindFromForgetPasswordWithSegue(segue: UIStoryboardSegue) {
    self.shouldSegueToLogin = true
}

Then present the wanted VC with present(_ viewControllerToPresent: UIViewController)

override func viewWillAppear(_ animated: Bool) {
    super.viewWillAppear(animated)
    let storyboard = UIStoryboard(name: "Main", bundle: nil)
    if self.shouldSegueToMainTabBar {
        let mainTabBarController = storyboard.instantiateViewController(withIdentifier: "mainTabBarVC") as! MainTabBarController
        self.present(mainTabBarController, animated: true)
        self.shouldSegueToMainTabBar = false
    }
    if self.shouldSegueToLogin {
        let loginController = storyboard.instantiateViewController(withIdentifier: "loginVC") as! LogInViewController
        self.present(loginController, animated: true)
        self.shouldSegueToLogin = false
    }
}

Basically, the above code will let me catch the unwind from login/SignUp VC and navigate to the dashboard, or catch the unwind action from forget password VC and navigate to the login page.

@Alper 2018-05-17 09:23:27

I fixed it by moving the start() function inside the dismiss completion block:

self.tabBarController.dismiss(animated: false) {
  self.start()
}

Start contains two calls to self.present() one for a UINavigationController and another one for a UIImagePickerController.

That fixed it for me.

@Cœur 2018-01-13 11:39:29

With your main window, there will likely always be times with transitions that are incompatible with presenting an alert. In order to allow presenting alerts at any time in your application lifecycle, you should have a separate window to do the job.

/// independant window for alerts
@interface AlertWindow: UIWindow

+ (void)presentAlertWithTitle:(NSString *)title message:(NSString *)message;

@end

@implementation AlertWindow

+ (AlertWindow *)sharedInstance
{
    static AlertWindow *sharedInstance;
    static dispatch_once_t onceToken;
    dispatch_once(&onceToken, ^{
        sharedInstance = [[AlertWindow alloc] initWithFrame:UIScreen.mainScreen.bounds];
    });
    return sharedInstance;
}

+ (void)presentAlertWithTitle:(NSString *)title message:(NSString *)message
{
    // Using a separate window to solve "Warning: Attempt to present <UIAlertController> on <UIViewController> whose view is not in the window hierarchy!"
    UIWindow *shared = AlertWindow.sharedInstance;
    shared.userInteractionEnabled = YES;
    UIViewController *root = shared.rootViewController;
    UIAlertController *alert = [UIAlertController alertControllerWithTitle:title message:message preferredStyle:UIAlertControllerStyleAlert];
    alert.modalInPopover = true;
    [alert addAction:[UIAlertAction actionWithTitle:@"OK" style:UIAlertActionStyleCancel handler:^(UIAlertAction *action) {
        shared.userInteractionEnabled = NO;
        [root dismissViewControllerAnimated:YES completion:nil];
    }]];
    [root presentViewController:alert animated:YES completion:nil];
}

- (instancetype)initWithFrame:(CGRect)frame
{
    self = [super initWithFrame:frame];

    self.userInteractionEnabled = NO;
    self.windowLevel = CGFLOAT_MAX;
    self.backgroundColor = UIColor.clearColor;
    self.hidden = NO;
    self.rootViewController = UIViewController.new;

    [NSNotificationCenter.defaultCenter addObserver:self
                                           selector:@selector(bringWindowToTop:)
                                               name:UIWindowDidBecomeVisibleNotification
                                             object:nil];

    return self;
}

/// Bring AlertWindow to top when another window is being shown.
- (void)bringWindowToTop:(NSNotification *)notification {
    if (![notification.object isKindOfClass:[AlertWindow class]]) {
        self.hidden = YES;
        self.hidden = NO;
    }
}

@end

Basic usage that, by design, will always succeed:

[AlertWindow presentAlertWithTitle:@"My title" message:@"My message"];

@vonox7 2016-07-29 19:34:35

It happened to me that the segue in the storyboard was some kind of broken. Deleting the segue (and creating the exact same segue again) solved the issue.

@Dannie P 2014-09-20 12:44:22

If other solutions does not look good for some reason, you can still use this good old workaround of presenting with the delay of 0, like this:

dispatch_after(0, dispatch_get_main_queue(), ^{
    finishViewController *finished = [self.storyboard instantiateViewControllerWithIdentifier:@"finishViewController"];
    [self presentViewController:finished animated:NO completion:NULL];    
});

While I've seen no documented guarantee that your VC would be on the view hierarchy on the time dispatch block is scheduled to execution, I've observed it would work just fine.

Using delay of e.g. 0.2 sec is also an option. And the best thing - this way you don't need to mess with boolean variable in viewDidAppear:

@Cruinh 2015-05-07 20:02:01

While this might work now, there's no guarantee that Apple will change behavior and break this on you in the future. Then when you go back to look at your code to try and fix things again, you'll wonder why you were doing this seemingly unnecessary dispatch.

@Dannie P 2015-05-08 06:43:21

Dispatch with 0 time has saved me quite a number of times already - sometimes things that just should logically work don't normally work without it. So just make comments for yourself and others on why you do unobvious things (not only such a dispatch) and you should be fine.

@Michael Peterson 2016-07-25 15:15:53

You are just hacking around the problem and not solving it.

@Dannie P 2016-07-25 20:00:47

@P1X3L5 that's a workaround, indeed

@Adam Johns 2017-05-17 01:59:47

My issue was I was performing the segue in UIApplicationDelegate's didFinishLaunchingWithOptions method before I called makeKeyAndVisible() on the window.

@shahtaj khalid 2017-09-13 07:11:51

how? can you elaborate? i'm facing the same problem. this is my code let initialViewControlleripad : UIViewController = mainStoryboardIpad.instantiateViewController(withIdentifier: "SplashController") as UIViewController self.window?.rootViewController = initialViewControlleripad self.window?.makeKeyAndVisible()

@Wes 2017-03-30 19:25:37

I had this issue, and the root cause was subscribing to a button click handler (TouchUpInside) multiple times.

It was subscribing in ViewWillAppear, which was being called multiple times since we had added navigation to go to another controller, and then unwind back to it.

@Devbot10 2017-01-17 00:30:48

With Swift 3...

Another possible cause to this, which happened to me, was having a segue from a tableViewCell to another ViewController on the Storyboard. I also used override func prepare(for segue: UIStoryboardSegue, sender: Any?) {} when the cell was clicked.

I fixed this issue by making a segue from ViewController to ViewController.

@igraczech 2016-02-22 17:42:19

I've ended up with such a code that finally works to me (Swift), considering you want to display some viewController from virtually anywhere. This code will obviously crash when there is no rootViewController available, that's the open ending. It also does not include usually required switch to UI thread using

dispatch_sync(dispatch_get_main_queue(), {
    guard !NSBundle.mainBundle().bundlePath.hasSuffix(".appex") else {
       return; // skip operation when embedded to App Extension
    }

    if let delegate = UIApplication.sharedApplication().delegate {
        delegate.window!!.rootViewController?.presentViewController(viewController, animated: true, completion: { () -> Void in
            // optional completion code
        })
    }
}

@igraczech 2016-02-22 17:45:00

BTW to understand WHERE do I call this method from... it's the otherwise UI-less SDK library, that displays its own UI over your app in certain (undisclosed) case.

@Anton Tropashko 2016-12-07 14:44:31

You WILL crash and burn if anyone decides to embed you sdk in an app that has an extension. Pass a UIViewController to abuse into you sdk init method[s].

@igraczech 2016-12-07 14:58:51

You're true Anton. This code was written when Extensions did not exist and SDK is not used in any of those yet. I've added a guard clause to skip this edge-case.

@HotFudgeSunday 2016-09-06 13:56:45

In case it helps anyone, my issue was extremely silly. Totally my fault of course. A notification was triggering a method that was calling the modal. But I wasn't removing the notification correctly, so at some point, I would have more than one notification, so the modal would get called multiple times. Of course, after you call the modal once, the viewcontroller that calls it it's not longer in the view hierarchy, that's why we see this issue. My situation caused a bunch of other issue too, as you would expect.

So to summarize, whatever you're doing make sure the modal is not being called more than once.

@vijay 2016-05-23 06:37:25

It's working fine try this.Link

UIViewController *top = [UIApplication sharedApplication].keyWindow.rootViewController;
[top presentViewController:secondView animated:YES completion: nil];

@abdul sathar 2016-03-09 06:22:53

For Display any subview to main view,Please use following code

UIViewController *yourCurrentViewController = [UIApplication sharedApplication].keyWindow.rootViewController;

while (yourCurrentViewController.presentedViewController) 
{
   yourCurrentViewController = yourCurrentViewController.presentedViewController;
}

[yourCurrentViewController presentViewController:composeViewController animated:YES completion:nil];

For Dismiss any subview from main view,Please use following code

UIViewController *yourCurrentViewController = [UIApplication sharedApplication].keyWindow.rootViewController;

while (yourCurrentViewController.presentedViewController) 
{
   yourCurrentViewController = yourCurrentViewController.presentedViewController;
}

[yourCurrentViewController dismissViewControllerAnimated:YES completion:nil];

@Alexander Huang 2016-10-05 01:43:45

This works for me :) Thanks you

@Aziz Javed 2017-03-08 14:53:34

Worked for me also

@reetu 2017-05-17 17:55:49

Thank you its working for me...

@Hari Narayanan 2017-07-03 11:20:08

yeah its..,,.. working/. great

@Faisal Syed 2018-11-29 01:54:21

This saved me!! Thank you!!!

@Coder_A_D 2016-02-18 10:17:54

Have to write below line.

self.searchController.definesPresentationContext = true

instead of

self.definesPresentationContext = true

in UIViewController

@Borzh 2015-12-02 21:06:54

You can also get this warning when performing a segue from a view controller that is embedded in a container. The correct solution is to use segue from the parent of container, not from container's view controller.

@Red 2015-09-09 10:41:17

I had the same issue. The problem was, the performSegueWithIdentifier was triggered by a notification, as soon as I put the notification on the main thread the warning message was gone.

@Aggressor 2015-08-17 19:48:23

TL;DR You can only have 1 rootViewController and its the most recently presented one. So don't try having a viewcontroller present another viewcontroller when it's already presented one that hasn't been dismissed.

After doing some of my own testing I've come to a conclusion.

If you have a rootViewController that you want to present everything then you can run into this problem.

Here is my rootController code (open is my shortcut for presenting a viewcontroller from the root).

func open(controller:UIViewController)
{
    if (Context.ROOTWINDOW.rootViewController == nil)
    {
        Context.ROOTWINDOW.rootViewController = ROOT_VIEW_CONTROLLER
        Context.ROOTWINDOW.makeKeyAndVisible()
    }

    ROOT_VIEW_CONTROLLER.presentViewController(controller, animated: true, completion: {})
}

If I call open twice in a row (regardless of time elapsed), this will work just fine on the first open, but NOT on the second open. The second open attempt will result in the error above.

However if I close the most recently presented view then call open, it works just fine when I call open again (on another viewcontroller).

func close(controller:UIViewController)
{
    ROOT_VIEW_CONTROLLER.dismissViewControllerAnimated(true, completion: nil)
}

What I have concluded is that the rootViewController of only the MOST-RECENT-CALL is on the view Hierarchy (even if you didn't dismiss it or remove a view). I tried playing with all the loader calls (viewDidLoad, viewDidAppear, and doing delayed dispatch calls) and I have found that the only way I could get it to work is ONLY calling present from the top most view controller.

@rayepps 2018-06-19 06:13:49

This seems like a far more common issue that the many answers that have out voted yours. Unfortunate, this was extremely helpful

@Mr Heelis 2019-05-09 11:13:41

yes all well and good but what is the solution... i have a background worker thread going to a server and displaying storyboards left right and centre and the entire methodology is bogus.. it's awful.. what should be a breeze is utterly a joke because al I want to do int he background thread is : wait wait decide push screen to front and it's IMPOSSIBLE is IOS????

@Vlad 2015-06-18 20:11:26

If you have AVPlayer object with played video you have to pause video first.

@Vlad 2015-07-07 19:42:08

I mean that video should be stopped/paused first.

@Vlad 2015-07-07 20:03:44

I have met this kind of issue several times at screen with AVPlayer object...

@Omar N Shamali 2016-03-31 16:15:54

actually this helped me, it led me after to this stackoverflow.com/questions/20746413/…

@Chris Nolet 2015-04-17 19:56:40

Another potential cause:

I had this issue when I was accidentally presenting the same view controller twice. (Once with performSegueWithIdentifer:sender: which was called when the button was pressed, and a second time with a segue connected directly to the button).

Effectively, two segues were firing at the same time, and I got the error: Attempt to present X on Y whose view is not in the window hierarchy!

@samouray 2015-05-12 07:39:14

I had the same error, and your answer here helped me figure out what was going on, it was indeed this error, fixed it because of you sir, thank you, +1

@MCB 2015-07-16 22:25:25

I deleted the old segue and connected VC to VC. Is there a way to connect the button to the storyBoard to the VC because that way just keeps erroring for me?

@burakgunduz 2016-05-01 19:27:06

I had same error, your answer solved my problem, thanks for your attention. Kind regards.

@Borzh 2017-03-31 14:12:48

lol, accidentally I also was creating two vc's: from button and performSegue, thanks for the tip!!!

@Samo 2018-04-11 19:43:43

In my case I was calling present(viewController, animated: true, completion: nil) inside a loop.

@James Bedford 2012-09-07 14:36:46

Where are you calling this method from? I had an issue where I was attempting to present a modal view controller within the viewDidLoad method. The solution for me was to move this call to the viewDidAppear: method.

My presumption is that the view controller's view is not in the window's view hierarchy at the point that it has been loaded (when the viewDidLoad message is sent), but it is in the window hierarchy after it has been presented (when the viewDidAppear: message is sent).


Caution

If you do make a call to presentViewController:animated:completion: in the viewDidAppear: you may run into an issue whereby the modal view controller is always being presented whenever the view controller's view appears (which makes sense!) and so the modal view controller being presented will never go away...

Maybe this isn't the best place to present the modal view controller, or perhaps some additional state needs to be kept which allows the presenting view controller to decide whether or not it should present the modal view controller immediately.

@Kyle Goslan 2012-09-21 21:35:23

Thanks for the reply, I'll have a look at this and see if its whats causing it

@Matt Mc 2012-09-24 01:50:20

@James you are correct, the view apparently is not in the hierarchy until after viewWillAppear has been resolved and once viewDidAppear has been called. If this were my question I would accept this answer ;)

@Ali 2012-10-07 14:42:26

@james Thanks. Using the ViewDidAppear solved the problem for me too. Makes sense.

@Schrockwell 2012-12-15 16:50:12

I wish I could upvote this twice. I just had this problem and came to the thread to find that I had already upvoted the last time I saw this.

@Vincent 2013-01-05 10:17:07

Note that when you change the VC in the viewDidAppear, this causes the execution of a segue, with Animation. Causes a flash/display of the background.

@BootMaker 2013-03-30 20:56:07

Yes the trick is the viewWillAppear:(BOOL)animated as it's correct. One more important thing you have to call the super in the method, as [super viewDidAppear:animated]; without this it's not working.

@surfrider 2014-04-09 08:04:42

Same problem as Vincent mentioned. When presenting in ViewWillAppear, i have flickering presenting view controller before presented is appears.

@love2script12 2015-05-12 04:58:20

For those who only looked at the upvoted answer, if you call if from AppDelegate, make sure it is called after [self.window makeKeyAndVisible]; Got this from another answer on this same page, but didn't want anyone to miss it

@Eugene Braginets 2016-07-19 18:12:17

if you have storyboard you can use perform segue and main_queue dispatch_async(dispatch_get_main_queue()) { }

@user3000868 2016-07-29 12:28:23

In case anyone else has this problem, I had a similar problem using NSNotifications to trigger a method to presentViewController. I saw this solution but didn't think it applied to me as my methods weren't being called in viewDidLoad but then realized I had the addObserver for each notification in viewWillLoad --> 'view is not in the window hierarchy' error. When I moved the 'addObserver' to viewDidAppear, the errors disappeared.

@Vaibhav Limbani 2017-04-28 12:30:14

@James Bedford Thanks ,you've saved my lot of time .Thank you very much :-)

@Jaydeep Vyas 2017-12-13 09:12:41

@James Bedford how to present view controller immediatly after the image is selected from gallery, because at the time uiimagepicker return me the image my controller is not appear

@Teo Sartori 2018-11-23 15:01:53

This answer should be turned into an Xcode warning.

@resting 2014-02-20 09:34:52

I had the same problem. I had to embed a navigation controller and present the controller through it. Below is the sample code.

- (void)viewDidLoad
{
    [super viewDidLoad];
    // Do any additional setup after loading the view, typically from a nib.

    UIImagePickerController *cameraView = [[UIImagePickerController alloc]init];
    [cameraView setSourceType:UIImagePickerControllerSourceTypeCamera];
    [cameraView setShowsCameraControls:NO];

    UIView *cameraOverlay = [[UIView alloc]initWithFrame:CGRectMake(0, 0, 768, 1024)];
    UIImageView *imageView = [[UIImageView alloc]initWithImage:[UIImage imageNamed:@"someImage"]];
    [imageView setFrame:CGRectMake(0, 0, 768, 1024)];
    [cameraOverlay addSubview:imageView];

    [cameraView setCameraOverlayView:imageView];

    [self.navigationController presentViewController:cameraView animated:NO completion:nil];
//    [self presentViewController:cameraView animated:NO completion:nil]; //this will cause view is not in the window hierarchy error

}

@Stephen J 2013-09-17 07:48:56

I just had this issue too, but it had nothing to do with the timing. I was using a singleton to handle scenes, and I set it as the presenter. In other words "Self" wasn't hooked up to anything. I just made its inner "scene" the new presenter and voila, it worked. (Voila loses its touch after you learn its meaning, heh).

So yeah, it's not about "magically finding the right way", it's about understanding where your code stands and what it's doing. I'm happy Apple gave such a plain-English warning message, even with emotion to it. Kudos to the apple dev who did that!!

@Sanbrother 2013-07-24 02:30:33

Probably, like me, you have a wrong root viewController

I want to display a ViewController in a non-UIViewController context,

So I can't use such code:

[self presentViewController:]

So, I get a UIViewController:

[[[[UIApplication sharedApplication] delegate] window] rootViewController]

For some reason (logical bug), the rootViewController is something other than expected (a normal UIViewController). Then I correct the bug, replacing rootViewController with a UINavigationController, and the problem is gone.

@Alejandro Luengo 2015-03-05 21:29:16

Works like charm

@Jonny 2013-02-22 03:10:41

viewWillLayoutSubviews and viewDidLayoutSubviews (iOS 5.0+) can be used for this purpose. They are called earlier than viewDidAppear.

@Jonny 2013-03-08 01:46:45

Still they are used also in other occasions so I think they might be called several times in a view's "lifetime".

@tooluser 2013-09-01 06:13:17

It's also not what the methods are for - as the name suggests. viewDidAppear is correct. Reading up on the view lifecycle is a good idea.

@TMilligan 2013-11-21 03:33:40

This is the best solution. In my case, presenting in viewDidAppear causes a split second showing of the view controller before the modal is loaded, which is unacceptable.

@uplearnedu.com 2016-01-07 21:31:05

This answer worked the best for me when trying to display an alert. The alert wouldn't show when I put it into viewDidLoad and viewWillAppear.

Related Questions

Sponsored Content

14 Answered Questions

1 Answered Questions

1 Answered Questions

1 Answered Questions

2 Answered Questions

3 Answered Questions

1 Answered Questions

[SOLVED] Error message: whose view is not in the window hierarchy - Swift

  • 2016-08-21 18:55:17
  • Stevic
  • 152 View
  • 0 Score
  • 1 Answer
  • Tags:   ios swift view

3 Answered Questions

0 Answered Questions

Warning: Attempt to present XXX on XXX whose view is not in the window hierarchy

  • 2013-11-09 02:56:49
  • HanXu
  • 2286 View
  • 2 Score
  • 0 Answer
  • Tags:   ios objective-c

Sponsored Content