By eko


2017-03-27 20:17:15 8 Comments

I have service which returns an observable which does an http request to my server and gets the data. I want to use this data but I always end up getting undefined. What's the problem?

Service:

@Injectable()
export class EventService {

  constructor(private http: Http) { }

  getEventList(): Observable<any>{
    let headers = new Headers({ 'Content-Type': 'application/json' });
    let options = new RequestOptions({ headers: headers });

    return this.http.get("http://localhost:9999/events/get", options)
                .map((res)=> res.json())
                .catch((err)=> err)
  }
}

Component:

@Component({...})
export class EventComponent {

  myEvents: any;

  constructor( private es: EventService ) { }

  ngOnInit(){
    this.es.getEventList()
        .subscribe((response)=>{
            this.myEvents = response;
        });

    console.log(this.myEvents); //This prints undefined!
  }
}

8 comments

@NhutLe 2019-03-09 13:32:31

The result is undefined because angular process async . you can trying as below:

async ngOnInit(){
    const res = await this.es.getEventList();
    console.log(JSON.stringify(res));
}

@Suneet Bansal 2019-03-04 09:39:10

Here the problem is, you are initializing this.myEvents into subscribe() which is an asynchronous block while you are doing console.log() just out of subscribe() block. So console.log() getting called before this.myEvents gets initialized.

Please move your console.log() code as well inside subscribe() and you are done.

ngOnInit(){
    this.es.getEventList()
        .subscribe((response)=>{
            this.myEvents = response;
            console.log(this.myEvents);
        });
  }

@luukgruijs 2017-03-27 20:27:20

Also make sure that you map your response to a json output. Otherwise it will return plain text. You do it this like this:

getEventList(): Observable<any> {
let headers = new Headers({ 'Content-Type': 'application/json' });
let options = new RequestOptions({ headers: headers });

return this.http.get("http://localhost:9999/events/get", options)
            .map((res)=>{ return res.json();}) <!-- add call to json here
            .catch((err)=>{return err;})
}

@Kooldandy 2018-09-23 10:37:17

Observables are lazy so you have to subscribe to get the value. You subscribed it properly in your code but simultaneously logged the output outside the 'subscribe' block. That's why it is 'undefined'.

ngOnInit() {
  this.es.getEventList()
    .subscribe((response) => {
        this.myEvents = response;
    });

  console.log(this.myEvents); //Outside the subscribe block 'Undefined'
}

So if you log it inside the subscribe block then it will log response properly.

ngOnInit(){
  this.es.getEventList()
    .subscribe((response)=>{
        this.myEvents = response;
        console.log(this.myEvents); //Inside the subscribe block 'http response'
    });
}

@Kliment Ru 2018-02-18 20:56:43

You can use asyncPype if you use myEvents only in template.

Here example with asyncPype and Angular4 HttpClient https://stackblitz.com/edit/angular-rhioqt?file=app%2Fevent.service.ts

@San Jay Falcon 2018-12-02 17:27:59

And (!) with this implementation one doesn't need to unsubscribe the Subscription: medium.com/@sub.metu/…

@AJT82 2019-04-22 10:36:56

@SanJayFalcon Since this is a http request, there is no need for unsubscription.

@eko 2017-03-27 20:17:15

Reason:

The reason that it's undefined is that you are making an asynchronous operation. Meaning it'll take some time to complete the getEventList method (depending mostly on your network speed).

So lets look at the http call.

this.es.getEventList()

After you actually make ("fire") your http request with subscribe you will be waiting for the response. While waiting, javascript will execute the lines below this code and if it encounters synchronous assignments/operations it'll execute them immediately.

So after subscribing to the getEventList() and waiting for the response,

console.log(this.myEvents);

line will be executed immediately. And the value of it is undefined before the response arrives from the server (or to whatever that you have initialized it in the first place).

It is similar to doing:

ngOnInit(){
    setTimeout(()=>{
        this.myEvents = response;
    }, 5000);

    console.log(this.myEvents); //This prints undefined!
}


Solution:

So how do we overcome this problem? We will use the callback function which is the subscribe method. Because when the data arrives from the server it'll be inside the subscribe with the response.

So changing the code to:

this.es.getEventList()
    .subscribe((response)=>{
        this.myEvents = response;
        console.log(this.myEvents); //<-- not undefined anymore
    });

will print the response.. after some time.


What you should do:

There might be lots of things to do with your response other than just logging it; you should do all these operations inside the callback (inside the subscribe function), when the data arrives.

Another thing to mention is that if you come from a Promise background, the then callback corresponds to subscribe with observables.


What you shouldn't do:

You shouldn't try to change an async operation to a sync operation (not that you can). One of the reasons that we have async operations is to not make the user wait for an operation to complete while they can do other things in that time period. Suppose that one of your async operations takes 3 minutes to complete, if we didn't have the async operations the interface would froze for 3 minutes.


Suggested Reading:

The original credit to this answer goes to: How do I return the response from an asynchronous call?

But with the angular2 release we were introduced to typescript and observables so this answer hopefully covers the basics of handling an asynchronous request with observables.

@Jonas Praem 2018-12-21 23:39:21

When a question is answered by the questioner at the exact same time of the post.. This is a good place to stop and write a blog post instead

@Amit Chigadani 2018-12-23 15:33:27

@JonasPraem True, but there is nothing wrong in sharing the knowledge on Stackoverflow. As you see the number of votes, it did help many people here and it will continue to do so.

@Harshit 2017-06-10 09:22:26

You can simply try this method-

let headers = new Headers({'Accept': 'application/json'});
let options = new RequestOptions({headers: headers});

return this.http
    .get(this.yourSearchUrlHere, options) // the URL which you have defined
    .map((res) => {
        res.json(); // using return res.json() will throw error
    }
    .catch(err) => {
        console.error('error');
    }

@RAVI PATEL 2017-05-20 06:13:24

Making a http call in angular/javascript is asynchronous operation. So when you make http call it will assign new thread to finish this call and start execution next line with another thread. That is why you are getting undefined value. so make below change to resolve this

this.es.getEventList()  
      .subscribe((response)=>{  
       this.myEvents = response;  
        console.log(this.myEvents); //<-this become synchronous now  
    });

Related Questions

Sponsored Content

89 Answered Questions

[SOLVED] How do I remove a particular element from an array in JavaScript?

  • 2011-04-23 22:17:18
  • Walker
  • 6158230 View
  • 7682 Score
  • 89 Answer
  • Tags:   javascript arrays

41 Answered Questions

[SOLVED] How do I remove a property from a JavaScript object?

5 Answered Questions

[SOLVED] Angular HTTP request error: "post valid request"

  • 2018-06-19 11:18:02
  • Shiva
  • 651 View
  • 0 Score
  • 5 Answer
  • Tags:   angular

36 Answered Questions

[SOLVED] How do I return the response from an asynchronous call?

31 Answered Questions

[SOLVED] How to manage a redirect request after a jQuery Ajax call

18 Answered Questions

21 Answered Questions

[SOLVED] How and when to use ‘async’ and ‘await’

1 Answered Questions

1 Answered Questions

How to Inject services with Async call on constructor, Angular 2

Sponsored Content